LCORE-971: ensure that type hints are checked for integration tetss

[tisnik]

Description

LCORE-971: ensure that type hints are checked for integration tetss

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement

Related Tickets & Documents

• Related Issue #LCORE-971

Summary by CodeRabbit

• Chores
  • Updated test execution configuration to include integration tests in the test scope.
  • Expanded type checking to cover integration tests.

[coderabbitai]

Walkthrough

The Makefile was updated to expand the scope of test execution and type checking. The test-unit target now runs both unit and integration tests, while the check-types target extends mypy validation to include integration tests. Formatting was also cleaned up.

Changes

Cohort / File(s)	Summary
Makefile test and type-check configuration Makefile	Modified test-unit target to include tests/integration alongside tests/unit; extended check-types target to run mypy against both test directories; removed extra blank lines

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

• Straightforward tooling configuration changes with no logic modifications
• Changes are minimal and follow obvious intent (expanding test scope)

Possibly related PRs

• LCORE-885: type hints in integration tests #719: Adds type hints to integration tests to ensure compatibility with the expanded mypy scope in check-types
• LCORE-740: check type hints for unit tests on CI #758: Previous Makefile modifications to check-types target that may have similar goals or interact with these changes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title contains a typo ('tetss' instead of 'tests') and is otherwise related to the main change of extending type checks to integration tests.	Correct the typo: change 'tetss' to 'tests'. The corrected title should read 'LCORE-971: ensure that type hints are checked for integration tests'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between be259e2 and 395c507.

📒 Files selected for processing (1)

• Makefile (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: build-pr
• GitHub Check: e2e_tests (ci)
• GitHub Check: e2e_tests (azure)
• GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request

🔇 Additional comments (2)

Makefile (2)

24-25: Correctly extends type checking to integration tests.

The addition of tests/integration to the mypy command achieves the PR objective of ensuring type hints are validated in integration tests. The change is minimal, focused, and appropriately aligns with the stated goal.

---

1-25: Inconsistency between AI summary and actual changes.

The AI-generated summary claims that test-unit was modified to include both tests/unit and tests/integration, and that "minor formatting change removed extra blank lines before test-unit." However, the provided annotated code shows only line 25 (in the check-types target) as modified. Line 14 (test-unit) is not marked with a ~ change indicator and still references only tests/unit. No evidence of extra blank lines being removed is visible in the provided output.

Please clarify whether:

1. test-unit was also modified to run integration tests (and if so, why the annotated code doesn't reflect this change), or
2. The summary is outdated and only the check-types target was changed.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}