LCORE-970: ensure that type hints are checked for end to end tets

[tisnik]

Description

LCORE-970: ensure that type hints are checked for end to end tets

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement

Related Tickets & Documents

• Related Issue #LCORE-970

Summary by CodeRabbit

• Chores
  • Enhanced type-checking coverage to include additional test directories.

[coderabbitai]

Walkthrough

The Makefile's check-types target was modified to extend mypy type-checking coverage by appending tests/e2e/ to the previously checked test directories.

Changes

Cohort / File(s)	Summary
Makefile type-checking scope extension Makefile	Extended check-types target to include tests/e2e/ directory in mypy type-checking scope

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

• Single-line configuration change with no logic modifications or new dependencies introduced

Possibly related PRs

• LCORE-971: ensure that type hints are checked for integration tetss #786: Also modifies the check-types target in the Makefile to extend mypy coverage to additional test directories (e2e tests).
• LCORE-740: check type hints for unit tests on CI #758: Similarly extends the check-types target to include test directories in mypy's scope, with related modifications to the Makefile configuration.

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title contains a typo ('tets' instead of 'tests') and is partially related to the changeset. The PR aims to ensure type hints are checked for end-to-end tests by extending the mypy check scope, but the typo undermines clarity.	Correct the typo from 'tets' to 'tests' in the title: 'LCORE-970: ensure that type hints are checked for end to end tests'

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

Makefile (1)

25-25: Normalize directory path formatting for consistency.

The change correctly extends mypy type-checking to tests/e2e/, aligning with the PR objective. However, there's a minor inconsistency: src/ and tests/e2e/ include trailing slashes, while tests/unit and tests/integration do not. Normalize the formatting by removing the trailing slash from tests/e2e/ to match the other test directories.

-	uv run mypy --explicit-package-bases --disallow-untyped-calls --disallow-untyped-defs --disallow-incomplete-defs --ignore-missing-imports --disable-error-code attr-defined src/ tests/unit tests/integration tests/e2e/
+	uv run mypy --explicit-package-bases --disallow-untyped-calls --disallow-untyped-defs --disallow-incomplete-defs --ignore-missing-imports --disable-error-code attr-defined src/ tests/unit tests/integration tests/e2e

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 91bfd1f and c62d9be.

📒 Files selected for processing (1)

• Makefile (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: build-pr
• GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
• GitHub Check: e2e_tests (azure)
• GitHub Check: e2e_tests (ci)

🔇 Additional comments (1)

Makefile (1)

25-25: Scope extension looks good.

The change successfully extends type-checking coverage from src/ tests/unit tests/integration to include tests/e2e, fulfilling the PR objective. The strict mypy configuration flags remain unchanged and appropriate for enforcing type safety across all test suites.