-
Notifications
You must be signed in to change notification settings - Fork 4
Add ZAR KES TSZ ZMW RWF account beneficiary information for grid #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| type: object | ||
| required: | ||
| - accountType | ||
| - countries | ||
| - paymentRails | ||
| - phoneNumber | ||
| - provider | ||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - KES_ACCOUNT | ||
| countries: | ||
| type: array | ||
| items: | ||
| type: string | ||
| enum: | ||
| - KE | ||
| paymentRails: | ||
| type: array | ||
| items: | ||
| type: string | ||
| enum: | ||
| - MOBILE_MONEY | ||
| phoneNumber: | ||
| type: string | ||
| description: Kenyan mobile money phone number | ||
| example: '+254712345678' | ||
| pattern: ^\+254[0-9]{9}$ | ||
| provider: | ||
| type: string | ||
| description: Mobile money provider | ||
| enum: | ||
| - M-PESA | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| title: Individual Beneficiary | ||
| type: object | ||
| required: | ||
| - beneficiaryType | ||
| - fullName | ||
| properties: | ||
| beneficiaryType: | ||
| type: string | ||
| enum: | ||
| - INDIVIDUAL | ||
| fullName: | ||
| type: string | ||
| description: The full name of the beneficiary | ||
| birthDate: | ||
| type: string | ||
| description: The birth date of the beneficiary | ||
| nationality: | ||
| type: string | ||
| description: The nationality of the beneficiary | ||
| email: | ||
| type: string | ||
| description: The email of the beneficiary | ||
| phoneNumber: | ||
| type: string | ||
| description: The phone number of the beneficiary | ||
| registrationNumber: | ||
| type: string | ||
| description: The registration number of the beneficiary | ||
| countryOfResidence: | ||
| type: string | ||
| description: The country of residence of the beneficiary | ||
| address: | ||
| $ref: ./Address.yaml |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| type: object | ||
| required: | ||
| - accountType | ||
| - countries | ||
| - paymentRails | ||
| - phoneNumber | ||
| - provider | ||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - RWF_ACCOUNT | ||
| countries: | ||
| type: array | ||
| items: | ||
| type: string | ||
| enum: | ||
| - RW | ||
| paymentRails: | ||
| type: array | ||
| items: | ||
| type: string | ||
| enum: | ||
| - MOBILE_MONEY | ||
| phoneNumber: | ||
| type: string | ||
| description: Rwandan mobile money phone number | ||
| example: '+250781234567' | ||
| pattern: ^\+250[0-9]{9}$ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Verify pattern Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/components/schemas/common/RwfAccountInfo.yaml
Line: 29
Comment:
Verify pattern `^\+250[0-9]{9}$` covers all valid MTN and AIRTEL mobile money numbers in Rwanda.
How can I resolve this? If you propose a fix, please make it concise. |
||
| provider: | ||
| type: string | ||
| description: Mobile money provider | ||
| enum: | ||
| - MTN | ||
| - AIRTEL | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| title: Individual Beneficiary | ||
| type: object | ||
| required: | ||
| - beneficiaryType | ||
| - fullName | ||
| properties: | ||
| beneficiaryType: | ||
| type: string | ||
| enum: | ||
| - INDIVIDUAL | ||
| fullName: | ||
| type: string | ||
| description: The full name of the beneficiary | ||
| birthDate: | ||
| type: string | ||
| description: The birth date of the beneficiary | ||
| nationality: | ||
| type: string | ||
| description: The nationality of the beneficiary | ||
| email: | ||
| type: string | ||
| description: The email of the beneficiary | ||
| phoneNumber: | ||
| type: string | ||
| description: The phone number of the beneficiary | ||
| registrationNumber: | ||
| type: string | ||
| description: The registration number of the beneficiary | ||
| countryOfResidence: | ||
| type: string | ||
| description: The country of residence of the beneficiary | ||
| address: | ||
| $ref: ./Address.yaml |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| type: object | ||
| required: | ||
| - accountType | ||
| - countries | ||
| - paymentRails | ||
| - phoneNumber | ||
| - provider | ||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - TZS_ACCOUNT | ||
| countries: | ||
| type: array | ||
| items: | ||
| type: string | ||
| enum: | ||
| - TZ | ||
| paymentRails: | ||
| type: array | ||
| items: | ||
| type: string | ||
| enum: | ||
| - MOBILE_MONEY | ||
| phoneNumber: | ||
| type: string | ||
| description: Tanzanian mobile money phone number | ||
| example: '+255712345678' | ||
| pattern: ^\+255[0-9]{9}$ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Verify pattern Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/components/schemas/common/TzsAccountInfo.yaml
Line: 29
Comment:
Verify pattern `^\+255[0-9]{9}$` covers all valid AIRTEL and VODACOM mobile money numbers in Tanzania.
How can I resolve this? If you propose a fix, please make it concise. |
||
| provider: | ||
| type: string | ||
| description: Mobile money provider | ||
| enum: | ||
| - AIRTEL | ||
| - VODACOM | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| title: Individual Beneficiary | ||
| type: object | ||
| required: | ||
| - beneficiaryType | ||
| - fullName | ||
| properties: | ||
| beneficiaryType: | ||
| type: string | ||
| enum: | ||
| - INDIVIDUAL | ||
| fullName: | ||
| type: string | ||
| description: The full name of the beneficiary | ||
| birthDate: | ||
| type: string | ||
| description: The birth date of the beneficiary | ||
| nationality: | ||
| type: string | ||
| description: The nationality of the beneficiary | ||
| email: | ||
| type: string | ||
| description: The email of the beneficiary | ||
| phoneNumber: | ||
| type: string | ||
| description: The phone number of the beneficiary | ||
| registrationNumber: | ||
| type: string | ||
| description: The registration number of the beneficiary | ||
| countryOfResidence: | ||
| type: string | ||
| description: The country of residence of the beneficiary | ||
| address: | ||
| $ref: ./Address.yaml |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| type: object | ||
| required: | ||
| - accountType | ||
| - countries | ||
| - paymentRails | ||
| - accountNumber | ||
| - bankName | ||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - ZAR_ACCOUNT | ||
| countries: | ||
| type: array | ||
| items: | ||
| type: string | ||
| enum: | ||
| - ZA | ||
| paymentRails: | ||
| type: array | ||
| items: | ||
| type: string | ||
| enum: | ||
| - BANK_TRANSFER | ||
| accountNumber: | ||
| type: string | ||
| description: South African bank account number | ||
| example: '1234567890' | ||
| minLength: 9 | ||
| maxLength: 13 | ||
| pattern: ^[0-9]{9,13}$ | ||
| bankName: | ||
| type: string | ||
| description: Name of the bank | ||
| example: Standard Bank |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| title: Individual Beneficiary | ||
| type: object | ||
| required: | ||
| - beneficiaryType | ||
| - fullName | ||
| properties: | ||
| beneficiaryType: | ||
| type: string | ||
| enum: | ||
| - INDIVIDUAL | ||
| fullName: | ||
| type: string | ||
| description: The full name of the beneficiary | ||
| birthDate: | ||
| type: string | ||
| description: The birth date of the beneficiary | ||
| nationality: | ||
| type: string | ||
| description: The nationality of the beneficiary | ||
| email: | ||
| type: string | ||
| description: The email of the beneficiary | ||
| phoneNumber: | ||
| type: string | ||
| description: The phone number of the beneficiary | ||
| registrationNumber: | ||
| type: string | ||
| description: The registration number of the beneficiary | ||
| countryOfResidence: | ||
| type: string | ||
| description: The country of residence of the beneficiary | ||
| address: | ||
| $ref: ./Address.yaml |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| type: object | ||
| required: | ||
| - accountType | ||
| - countries | ||
| - paymentRails | ||
| - phoneNumber | ||
| - provider | ||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - ZMW_ACCOUNT | ||
| countries: | ||
| type: array | ||
| items: | ||
| type: string | ||
| enum: | ||
| - ZM | ||
| paymentRails: | ||
| type: array | ||
| items: | ||
| type: string | ||
| enum: | ||
| - MOBILE_MONEY | ||
| phoneNumber: | ||
| type: string | ||
| description: Zambian mobile money phone number | ||
| example: '+260971234567' | ||
| pattern: ^\+260[0-9]{9}$ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Verify pattern Prompt To Fix With AIThis is a comment left during a code review.
Path: openapi/components/schemas/common/ZmwAccountInfo.yaml
Line: 29
Comment:
Verify pattern `^\+260[0-9]{9}$` covers all valid mobile money numbers for TNM, AIRTEL, ZAMTEL, and MTN in Zambia.
How can I resolve this? If you propose a fix, please make it concise. |
||
| provider: | ||
| type: string | ||
| description: Mobile money provider | ||
| enum: | ||
| - TNM | ||
| - AIRTEL | ||
| - ZAMTEL | ||
| - MTN | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| title: Individual Beneficiary | ||
| type: object | ||
| required: | ||
| - beneficiaryType | ||
| - fullName | ||
| properties: | ||
| beneficiaryType: | ||
| type: string | ||
| enum: | ||
| - INDIVIDUAL | ||
| fullName: | ||
| type: string | ||
| description: The full name of the beneficiary | ||
| birthDate: | ||
| type: string | ||
| description: The birth date of the beneficiary | ||
| nationality: | ||
| type: string | ||
| description: The nationality of the beneficiary | ||
| email: | ||
| type: string | ||
| description: The email of the beneficiary | ||
| phoneNumber: | ||
| type: string | ||
| description: The phone number of the beneficiary | ||
| registrationNumber: | ||
| type: string | ||
| description: The registration number of the beneficiary | ||
| countryOfResidence: | ||
| type: string | ||
| description: The country of residence of the beneficiary | ||
| address: | ||
| $ref: ./Address.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify pattern
^\+254[0-9]{9}$correctly validates all M-PESA numbers (check if 7xx, 1xx prefixes are the only valid ones for Kenya mobile money).Prompt To Fix With AI