Add ZAR KES TSZ ZMW RWF account beneficiary information for grid#231
Open
matthappens wants to merge 1 commit intomainfrom
Open
Add ZAR KES TSZ ZMW RWF account beneficiary information for grid#231matthappens wants to merge 1 commit intomainfrom
matthappens wants to merge 1 commit intomainfrom
Conversation
Contributor
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript Edit this comment to update them. They will appear in their respective SDK's changelogs. ✅ grid-python studio · code · diff
✅ grid-openapi studio · code · diff
⏳ grid-kotlin studio✅ grid-typescript studio · code · diff
⏳ These are partial results; builds are still running. This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push. |
matthappens
commented
Feb 25, 2026
cli/package-lock.json
Outdated
| "@types/node": "^20.0.0", | ||
| "ts-node": "^10.9.2", | ||
| "typescript": "^5.4.0" | ||
| }, |
Author
There was a problem hiding this comment.
we might be able to skip this
matthappens
force-pushed
the
02-25-add_zar_kes_tsz_zmw_rwf_account_beneficiary_information_for_grid
branch
from
3621b11 to
07d2ba8
Compare
Contributor
Greptile SummaryAdded support for 5 new African currencies (KES, RWF, TZS, ZAR, ZMW) with region-specific payment methods. The implementation follows existing patterns consistently across all new account types. Key Changes:
Note: The PR description mentions "Added Node.js engine requirement of >=18.0.0 in CLI package.json" but no package.json changes are present in this diff. This may need clarification. Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/common/KesAccountInfo.yaml | Added Kenya mobile money account schema with M-PESA provider and phone validation |
| openapi/components/schemas/common/RwfAccountInfo.yaml | Added Rwanda mobile money account schema with MTN and AIRTEL providers |
| openapi/components/schemas/common/TzsAccountInfo.yaml | Added Tanzania mobile money account schema with AIRTEL and VODACOM providers |
| openapi/components/schemas/common/ZarAccountInfo.yaml | Added South Africa bank transfer account schema with account number validation (9-13 digits) |
| openapi/components/schemas/common/ZmwAccountInfo.yaml | Added Zambia mobile money account schema with TNM, AIRTEL, ZAMTEL, and MTN providers |
| openapi/components/schemas/external_accounts/ExternalAccountInfoOneOf.yaml | Integrated all 5 new account types into discriminator mapping and oneOf schema |
| openapi/components/schemas/external_accounts/ExternalAccountType.yaml | Added all 5 new account type enums (KES, RWF, TZS, ZAR, ZMW) |
Last reviewed commit: 07d2ba8
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| type: string | ||
| description: Kenyan mobile money phone number | ||
| example: '+254712345678' | ||
| pattern: ^\+254[0-9]{9}$ |
Contributor
There was a problem hiding this comment.
Verify pattern ^\+254[0-9]{9}$ correctly validates all M-PESA numbers (check if 7xx, 1xx prefixes are the only valid ones for Kenya mobile money).
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/KesAccountInfo.yaml
Line: 29
Comment:
Verify pattern `^\+254[0-9]{9}$` correctly validates all M-PESA numbers (check if 7xx, 1xx prefixes are the only valid ones for Kenya mobile money).
How can I resolve this? If you propose a fix, please make it concise.| type: string | ||
| description: Rwandan mobile money phone number | ||
| example: '+250781234567' | ||
| pattern: ^\+250[0-9]{9}$ |
Contributor
There was a problem hiding this comment.
Verify pattern ^\+250[0-9]{9}$ covers all valid MTN and AIRTEL mobile money numbers in Rwanda.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/RwfAccountInfo.yaml
Line: 29
Comment:
Verify pattern `^\+250[0-9]{9}$` covers all valid MTN and AIRTEL mobile money numbers in Rwanda.
How can I resolve this? If you propose a fix, please make it concise.| type: string | ||
| description: Tanzanian mobile money phone number | ||
| example: '+255712345678' | ||
| pattern: ^\+255[0-9]{9}$ |
Contributor
There was a problem hiding this comment.
Verify pattern ^\+255[0-9]{9}$ covers all valid AIRTEL and VODACOM mobile money numbers in Tanzania.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/TzsAccountInfo.yaml
Line: 29
Comment:
Verify pattern `^\+255[0-9]{9}$` covers all valid AIRTEL and VODACOM mobile money numbers in Tanzania.
How can I resolve this? If you propose a fix, please make it concise.| type: string | ||
| description: Zambian mobile money phone number | ||
| example: '+260971234567' | ||
| pattern: ^\+260[0-9]{9}$ |
Contributor
There was a problem hiding this comment.
Verify pattern ^\+260[0-9]{9}$ covers all valid mobile money numbers for TNM, AIRTEL, ZAMTEL, and MTN in Zambia.
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/common/ZmwAccountInfo.yaml
Line: 29
Comment:
Verify pattern `^\+260[0-9]{9}$` covers all valid mobile money numbers for TNM, AIRTEL, ZAMTEL, and MTN in Zambia.
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Added support for 5 new African currencies (KES, RWF, TZS, ZAR, ZMW) with mobile money and bank transfer payment methods, plus set minimum Node.js version requirement to 18.0.0.
What changed?
How to test?
Why make this change?
This change expands payment coverage to key African markets by adding support for popular local payment methods like M-PESA in Kenya and various mobile money providers across East and Southern Africa.