Expose APIs to access node's supported feature flags#810
Draft
enigbe wants to merge 1 commit intolightningdevkit:mainfrom
Draft
Expose APIs to access node's supported feature flags#810enigbe wants to merge 1 commit intolightningdevkit:mainfrom
enigbe wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
With this, we can read the features supported by the node as announced in node and channel announcements, within an init message, and within a BOLT 11 invoice. We write a small integration test to assert that, at minimum, certain features are supported by default, for example, keysend support.
|
👋 Hi! This PR is now in draft status. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Expose APIs to access the node's supported feature flags. The public API on
Nodeinclude:node_features()init_features()channel_features()bolt11_invoice_features()With this, we can read the features supported by the node as used in node announcements, channel announcements, init messages, and BOLT 11 invoices. The plan is to modify
ldk-server'shandle_get_node_info_requestand make features available onGetNodeInfoResponseso that the node's supported features are available to any requesting client.lnrpcandcln-grpcmake these fields available in the response toget_node_info.Additionally, we write a small integration test to assert that, at minimum, certain features are supported by default, for example,
keysend.This is in relation to an exploratory
sim-lnPR seeking to support/integrateldk-node/server.