Add network and feature flags to GetNodeInfoResponse#1
Open
Conversation
5bd859e to
b873ddd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
To run simulations of payment activity against a network with
ldk-node/server,sim-lnrequires knowledge of the nodes network and whether it supportskeysend. These data points are not readily available on the library (node) and the daemon (server). This PR, in conjunction with exposed APIs in lightningdevkit/ldk-node#810, adds two new fields:networkandfeaturesto theGetNodeInfoResponse. We try to maintain parity with similar node info responses as doeslnrpcandcln-grpc.