allow adding a tip whose origin is older than the root#88
Open
josephwb wants to merge 1 commit intoliamrevell:masterfrom
Open
allow adding a tip whose origin is older than the root#88josephwb wants to merge 1 commit intoliamrevell:masterfrom
josephwb wants to merge 1 commit intoliamrevell:masterfrom
Conversation
Allow adding an outgroup tip which diverged before the ingroup MRCA.the `ape::bind.tree` function which `bind.tip` wraps allows this, but the tree to which the tip is added ("x") must have a `root.edge`. The code submitted here does the necessary edits so that `bind.tree` does what is requested with no more arguments required from the user.
Contributor
Author
|
Anyway, this arose from a student wanting to an an extinct outgroup to her extant tree, which did not seem possible with the existing version of HTH. |
Contributor
Author
|
Ping. If you are not interested in this, that is totally fine. Just please reject the PR so I can delete my fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow adding an outgroup tip which diverged before the ingroup MRCA. The
ape::bind.treefunction whichbind.tipwraps allows this, but the tree to which the tip is added ("x") must have aroot.edge. The code submitted here does the necessary edits so thatbind.treedoes what is requested with no more arguments required from the user.Examples