Skip to content

🎨 fix: unify label-field spacing across form components #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
futjesus merged 1 commit into from
Feb 12, 2026
Merged

🎨 fix: unify label-field spacing across form components #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/components/Autocomplete/Autocomplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ const Autocomplete = forwardRef<HTMLInputElement, AutocompleteProps>(
return (
<div
ref={wrapperRef}
className="relative flex flex-col"
className="relative flex flex-col gap-2"
data-theme={theme}
>
{label ? (
Expand Down
7 changes: 1 addition & 6 deletions lib/components/Autocomplete/Autocomplete.variants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,4 @@ export const autocompleteVariants = cva([
'kubefirst:focus:ring-kubefirst-primary',
]);

export const labelVariants = cva([
'pl-1',
'mb-2',
'text-base',
'cursor-pointer',
]);
export const labelVariants = cva(['pl-1', 'text-base', 'cursor-pointer']);
2 changes: 1 addition & 1 deletion lib/components/Counter/Counter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export const Counter: FC<CounterProps> = forwardRef<
}, [count, max, onChange]);

return (
<div className="flex flex-col gap-1" data-theme={theme}>
<div className="flex flex-col gap-2" data-theme={theme}>
{label ? (
<div className={cn(labelWrapperClassName)}>
<Typography
Expand Down
3 changes: 2 additions & 1 deletion lib/components/MultiSelectDropdown/MultiSelectDropdown.variants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@ import { cva } from 'class-variance-authority';
export const wrapperVariants = cva([
'flex',
'flex-col',
'gap-2',
'w-full',
'relative',
'cursor-pointer',
]);

export const labelVariants = cva(['cursor-pointer', 'mb-1', 'select-none']);
export const labelVariants = cva(['cursor-pointer', 'select-none']);

export const multiSelectDropdownVariants = cva([
'min-h-9',
Expand Down
1 change: 0 additions & 1 deletion lib/components/Select/Select.variants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ export const inputVariants = cva([
]);

export const labelVariants = cva([
'mb-1',
'cursor-pointer',
'text-sm',
'leading-5',
Expand Down
2 changes: 1 addition & 1 deletion lib/components/Select/components/Wrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ export const Wrapper: ForwardRefExoticComponent<
return (
<div
ref={wrapperRef}
className={cn('flex flex-col w-full relative', wrapperClassName)}
className={cn('flex flex-col gap-2 w-full relative', wrapperClassName)}
data-theme={theme}
>
{label ? (
Expand Down
3 changes: 2 additions & 1 deletion lib/components/TagSelect/TagSelect.variants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,13 @@ import { cva } from 'class-variance-authority';
export const wrapperVariants = cva([
'flex',
'flex-col',
'gap-2',
'w-full',
'relative',
'text-zinc-500',
]);

export const labelVariants = cva(['my-2', 'cursor-pointer']);
export const labelVariants = cva(['cursor-pointer']);

export const tagSelectVariants = cva([
'border',
Expand Down