🎨 fix: unify label-field spacing across form components#518
Merged
Conversation
Standardize all form components to use gap-2 (8px) between label and field, matching the pattern already used by Input, TextArea, TimePicker, PhoneNumberInput, and ImageUpload. - Select: add gap-2 to wrapper, remove mb-1 from label - Counter: change gap-1 to gap-2 in wrapper - Autocomplete: add gap-2 to wrapper, remove mb-2 from label - TagSelect: add gap-2 to wrapper, remove my-2 from label - MultiSelectDropdown: add gap-2 to wrapper, remove mb-1 from label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gap-2(8px) between label and field, matching the pattern already used by Input, TextArea, TimePicker, PhoneNumberInput, and ImageUploadmb-1,mb-2,my-2,gap-1) from 5 components and replaces it with a unifiedgap-2on the flex-col wrapperTest plan
npm run check:types— no type errorsnpm run test— all 394 tests passnpm run lint— no lint issues