Skip to content

fix crash for UPS due to json conversion error for null value in weightUnit #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
itsvic-dev merged 1 commit into from
Oct 30, 2025
Merged

fix crash for UPS due to json conversion error for null value in weightUnit #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions app/src/main/java/dev/itsvic/parceltracker/api/UPSDeliveryService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,11 @@ object UPSDeliveryService : DeliveryService {
else -> logUnknownStatus("UPS", details.progressBarType!!)
}

val metadata =
mutableMapOf(
R.string.property_weight to
"${details.additionalInformation!!.weight} ${details.additionalInformation.weightUnit}",
)
val metadata = mutableMapOf<Int, String>()
if (details.additionalInformation?.weightUnit != null) {
metadata[R.string.property_weight] =
"${details.additionalInformation.weight} ${details.additionalInformation.weightUnit}"
}

// ETA
if (details.scheduledDeliveryDateDetail != null && details.packageStatusTime != null) {
Expand Down Expand Up @@ -188,7 +188,7 @@ object UPSDeliveryService : DeliveryService {
@JsonClass(generateAdapter = true)
internal data class PkgMoreInfo(
val weight: String,
val weightUnit: String,
val weightUnit: String?,
)

@JsonClass(generateAdapter = true)
Expand Down