fix crash for UPS due to json conversion error for null value in weightUnit#180
Merged
itsvic-dev merged 1 commit intoitsvic-dev:masterfrom Oct 30, 2025
Merged
Conversation
…htUnit -> make the weightUnit optional (nullable) and do not list it as a metadata property in the view if it is null TODO: add defensive error handling to avoid crashes like that in the future, caused by unversioned proprietary APIs suddenly changing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix crash for UPS due to json conversion error for null value in weightUnit
-> make the weightUnit optional (nullable) and do not list it as a metadata property in the view if it is null
closes #179
For the future, defensive error handling should be added to avoid crashes caused by unversioned proprietary APIs suddenly changing