-
Notifications
You must be signed in to change notification settings - Fork 3k
Adds Initial Support For Multi-Backend Sensors #4490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Initial Support For Multi-Backend Sensors #4490
Conversation
|
Too many files changed for review. ( |
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
| @property | ||
| @abstractmethod | ||
| def contact_pos_w(self) -> torch.Tensor | None: | ||
| """Average position of contact points. Shape is (N, B, M, 3). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for ones that Newton or PhysX don't have support yet, might be useful to add a note in the docstring to mention Newton-only or PhysX-only so that when users look through the APIs, they'll know what to expect on which APIs will be available for their backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that would be reasonable. Can it wait till the newton stack makes it in? It may have support for those things by then?
… way we actually do it!
Updates to latest develop and update test thresholds
Signed-off-by: Kelly Guo <kellyg@nvidia.com>
Description
This PR extends the multi-backend architecture to the sensor classes (
ContactSensor,Imu,FrameTransformer) following the same pattern established for asset classes in theantoiner/multi-backendbranch.Created abstract base classes for sensors in
isaaclab:BaseContactSensorandBaseContactSensorDataBaseImuandBaseImuDataBaseFrameTransformerandBaseFrameTransformerDataConverted existing sensor classes and data classes to factory wrappers using the
FactoryBasepatternMoved PhysX-specific sensor implementations to
isaaclab_physx:isaaclab_physx.sensors.ContactSensorandContactSensorDataisaaclab_physx.sensors.ImuandImuDataisaaclab_physx.sensors.FrameTransformerandFrameTransformerDataMoved PhysX-specific sensor tests to
isaaclab_physx/test/sensors/Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there