-
Notifications
You must be signed in to change notification settings - Fork 15
Feature/install outside docker pycharm debug #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d49ed2d to
1620143
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copying over my comment from the old MR (#321).
I suggest that we (automatically) test this script, somehow, to ensure that it doesn't break as the project evolves. I would suggest that we add a task to ci.yml that uses this script to install on a base ubuntu container.
We could add this test in a follow up MR though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing!! Thanks for doing this. I have a small request if you have time :)
Can this be split into multiple files. Like isaaclab_arena.sh contains only the CLI and then calls other funtions which can be under scripts called uv.sh, pycharm.sh, install.sh, python.sh etc. It would look much nicer and the user will see less code that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I just pushed, please check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing
viiik-inside
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot
Summary
Detailed description
How to use
Installation:
Create Virtual Environment:
isaaclab_arena.sh -u [env_name]isaaclab_arena.sh -c [env_name]Install Isaac Lab Arena:
isaaclab_arena.sh -i [framework_name]Pycharm Debugging:
Add Debugger Config (First Time):
isaaclab_arena.sh -yComplete Debugger Config :
isaaclab_arena.sh -y