refactor: move multiaddr helpers to @multiformats #3075
+8,893
−5,409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v8-compile-cache breaks dynamic import() in this process.
electron-serve is ESM in newer versions, which breaks CommonJS require(). Kick off electron-serve initialization at module load and await it during init so the webui:// scheme is registered before we create windows / load URLs.
Prep for updating i18next-icu: newer versions are ESM-only, so require() breaks. Dynamic import works with both CommonJS and ESM.
Follow up to the ESM loader change so we can use the newer electron-serve release.
Use newer i18next-icu which requires intl-messageformat >=10.3.3.
We no longer use it (dynamic import breaks with it enabled).
Pin electron-builder to match the app-builder-lib patch and keep installs deterministic. The patch keeps the schema tweak that allows azureSignOptions.publisherName to be a string.
Keep patching dependencies during postinstall with the current patch-package release.
Keep electron-store on a known CJS-compatible release.
Refresh common dev tools (cross-env, dotenv, got, shx, sinon, tmp, semver-regex).
Keep fs-extra current.
Align address handling with the multiaddr stack used by newer IPFS tooling.
This was referenced Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the app's multiaddr parsing/conversion helpers to the
@multiformatspackages.This is prep work for the upcoming daemon RPC client migration. For now the dependency versions match what the current
ipfs-*stack expects sonpm cistays reproducible. Follow-up PRs will continue the daemon RPC migration (multiaddr addr fixes, thenkubo-rpc-client, thenipfsd-ctlupdates).Linting is expected to fail, since #3066 introduced a new linter. :)
Tray icon is expected to not show that the daemon is online, because of current limitations in the dependencies, see #3073.
Testing: I can only test on Linux, and I tested the core functionality of the app with Electron
39.5.1.Note: This commit contains the changes of PR #3048, #3049, #3050, #3051, #3052, #3053, #3054, #3055, #3056, #3058, #3059, #3060, #3061, #3062, #3063, #3064, #3065, #3066, #3067, #3068, #3069, #3070, #3071, #3072, #3073 and #3074, as soon as they are accepted, I'll remove those commits.