daemon: continue startup if ipfs daemon is malfunctioning #3087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v8-compile-cache breaks dynamic import() in this process.
electron-serve is ESM in newer versions, which breaks CommonJS require(). Kick off electron-serve initialization at module load and await it during init so the webui:// scheme is registered before we create windows / load URLs.
Prep for updating i18next-icu: newer versions are ESM-only, so require() breaks. Dynamic import works with both CommonJS and ESM.
Follow up to the ESM loader change so we can use the newer electron-serve release.
Use newer i18next-icu which requires intl-messageformat >=10.3.3.
We no longer use it (dynamic import breaks with it enabled).
Pin electron-builder to match the app-builder-lib patch and keep installs deterministic. The patch keeps the schema tweak that allows azureSignOptions.publisherName to be a string.
Keep patching dependencies during postinstall with the current patch-package release.
Keep electron-store on a known CJS-compatible release.
Refresh common dev tools (cross-env, dotenv, got, shx, sinon, tmp, semver-regex).
Keep fs-extra current.
Align address handling with the multiaddr stack used by newer IPFS tooling.
Port probing should work with /http-encapsulated multiaddrs as well.
Use the Kubo RPC client for daemon API calls.
Use the current ipfsd-ctl node factory for daemon lifecycle.
Avoid failing startup checks when process state is not available.
Provide a stable default when no explicit repository path is configured.
Prevent old API socket metadata from blocking daemon startup.
Handle brief API warmup after the daemon reports ready.
Keep daemon startup moving when early RPC calls are briefly unavailable.
Ensure RPC clients receive a consistent URL shape from daemon addresses.
Give RPC initialization more time and report resolved addresses.
Keep startup responsive while RPC endpoint finishes warming up.
If startup returns without a peer id, retry id() once with a short timeout. If that still fails, continue startup instead of treating it as a blocker. This keeps the UI and tray usable, including when a configured custom binary path is valid but the binary does not actually start and the user needs to switch back to the bundled binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a malfunctioning binary as test revealed that it will block the startup indefinitely, making the tray action to reset the IPFS Daemon binary back to the internal one unavailable to the user.
This PR addresses this UX blocker by retrying for a limited amount of time to fetch the ID, if it's not available, and then ignoring this error and starting up the UI in an offline state.
Linting is expected to fail, since #3066 introduced a new linter. :)
Testing: I can only test on Linux, and I tested the core functionality of the app with Electron
39.5.1.Note: This commit contains the changes of PR #3048, #3049, #3050, #3051, #3052, #3053, #3054, #3055, #3056, #3058, #3059, #3060, #3061, #3062, #3063, #3064, #3065, #3066, #3067, #3068, #3069, #3070, #3071, #3072, #3073, #3074, #3075, #3076, #3077, #3078, #3079, #3080, #3081, #3082, #3083, #3084, #3085, and #3086 as soon as they are accepted, I'll remove those commits.