Uses tool cache - skips wrapper create on hit.#94
Open
jcuffe wants to merge 2 commits intohashicorp:mainfrom
Open
Uses tool cache - skips wrapper create on hit.#94jcuffe wants to merge 2 commits intohashicorp:mainfrom
jcuffe wants to merge 2 commits intohashicorp:mainfrom
Conversation
|
|
Contributor
|
Thank you for the contribution @jcuffe! Apologies on the delay in reviewing your PR. I appreciate that you've added tests for this use case as well. I'll be reviewing this PR this week. |
|
@jpogran any time to review this. |
|
@jpogran Any time to review this yet? |
|
this action still doesn't support tool cache. any chance in reviewing this @austinvalle ? happy to create a new PR if the author is no longer available |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that this library was using the
actions/tool-cache, which has great helpers for saving and loading from the runner cache.I wanted this for my own project in order to save resources on my free Github plan. I recently learned that
actions/cacheworks well withactions/tool-cache, even on Github runners, so this could be useful to others as well!The existing API is maintained. The only logic change necessary aside from checking the cache, was to skip creation of the wrapper when loading from cache (to prevent the
terraform-binterraform executable from being replaced with the cached wrapper script living interraform).Let me know if any further changes are necessary to integrate!