Use toolcache properly to download terraform#202
Open
shahariaazam wants to merge 4 commits intohashicorp:mainfrom
Open
Use toolcache properly to download terraform#202shahariaazam wants to merge 4 commits intohashicorp:mainfrom
shahariaazam wants to merge 4 commits intohashicorp:mainfrom
Conversation
Contributor
|
Thank you for the contribution @shahariaazam! There is an existing PR #94 that is attempting to do the same work as yours. Can you comment on how your approach is different? I also think you'll need to run the build step to generate the dist files. |
Author
Cool! I didn't see that PR. #94 this also covered wrapper stuff as well. You can review any one of the PRs. If the author respond quickly you can review and merge that, otherwise I can add tests and cover wrapper stuff here as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly use GitHub toolcache to avoid repeated download each time. Previously toolcache was just used to download the binary but it was not storing the downloaded binary to cache.
Now, it will check if the tool is exist in GitHub toolcache or not. If exists, it will not download the binary again and use the cache path instead.
Debug logs when tool not exists in cache
Debug logs when the tool already in cache.