Skip to content

Fix ghe.com implementation #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gustavkj wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −2
Open

Fix ghe.com implementation #522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 21 additions & 2 deletions src/git/repository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,24 @@ interface GitHubUrls {
protocol: Protocol;
}

const gitRemotePattern =
/^(?:(?:(?:git|ssh|rsync|https?):\/\/)?(?:(?:git|\w+)@)?(?<host>[\w.]+))(?:[\w.@:/\-~]+)(?:\.git)\/?$/;

function isGithubEnterpriseCloudWithDataResidencyRemote(pushUrl?: string): boolean {
if (!pushUrl) {
return false;
}

try {
const url = new URL(pushUrl);
return url.host.endsWith(".ghe.com");
} catch (_error) {
const match = gitRemotePattern.exec(pushUrl);

return Boolean(match?.groups?.host?.endsWith(".ghe.com"));
Comment on lines +29 to +33
Copy link
Contributor

@jsoref jsoref Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like all of these endsWith(".ghe.com") https://github.com/search?q=repo%3Agithub%2Fvscode-github-actions%20ghe.com&type=code should be converted into a function to reduce code duplication and tell a better story.

}
}

async function getGitExtension(): Promise<API | undefined> {
const gitExtension = vscode.extensions.getExtension<GitExtension>("vscode.git");
if (gitExtension) {
Expand Down Expand Up @@ -77,8 +95,9 @@ export async function getGitHubUrls(): Promise<GitHubUrls[] | null> {
if (
remote.length > 0 &&
(remote[0].pushUrl?.indexOf("github.com") !== -1 ||
(useEnterprise() && remote[0].pushUrl?.indexOf(new URL(getGitHubApiUri()).host) !== -1) ||
(remote[0].pushUrl ? new URL(remote[0].pushUrl).host.endsWith(".ghe.com") : false))
(useEnterprise() &&
(remote[0].pushUrl?.indexOf(new URL(getGitHubApiUri()).host) !== -1 ||
isGithubEnterpriseCloudWithDataResidencyRemote(remote[0].pushUrl))))
) {
const url = remote[0].pushUrl;

Expand Down