Fix ghe.com implementation #522
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoref
reviewed
Dec 30, 2025
Comment on lines
+29
to
+33
| return url.host.endsWith(".ghe.com"); | ||
| } catch (_error) { | ||
| const match = gitRemotePattern.exec(pushUrl); | ||
|
|
||
| return Boolean(match?.groups?.host?.endsWith(".ghe.com")); |
Contributor
There was a problem hiding this comment.
It feels like all of these endsWith(".ghe.com") https://github.com/search?q=repo%3Agithub%2Fvscode-github-actions%20ghe.com&type=code should be converted into a function to reduce code duplication and tell a better story.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #502
Adds support for non-URL formatted remotes for ghe.com repos, e.g.
company@company.ghe.com:org/repo.git. To do this safely, the remote is parsed using regex and the host is extracted. This should better be aligned with the security concerns raised in #469.