Skip to content

feat: enforce aggregate deprecation #7684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kylemumma wants to merge 3 commits into
base: master
Choose a base branch
from
+7 −6
Open

feat: enforce aggregate deprecation #7684

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfe9932
init
Jan 29, 2026
3e19de2
rmove
Jan 29, 2026
0a4bd8b
runtime
Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions snuba/web/rpc/v1/resolvers/R_eap_items/resolver_time_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,12 +469,13 @@ def resolve(
# if the user passes it in
assert len(in_msg.aggregations) == 0

# This metric is expected to be 0, aggregation is deprecated and should be converted to
# conditional aggregation. This metric is to verify before deprecating in the protobuf.
# @kylemumma 01/27/2026
for expr in in_msg.expressions:
if expr.WhichOneof("expression") == "aggregation":
self._metrics_backend.increment("aggregation_expression")
# aggregation is deprecated, it gets converted to conditional_aggregation
if state.get_int_config("aggregation_deprecation_enabled", 1):
for expr in in_msg.expressions:
if expr.WhichOneof("expression") == "aggregation":
raise RuntimeError(
"Unexpected state: aggregation is deprecated and should have been converted to conditional_aggregation"
)

query_settings = setup_trace_query_settings() if in_msg.meta.debug else HTTPQuerySettings()
try:
Expand Down
Loading