feat: enforce aggregate deprecation #7684
Open
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volokluev
reviewed
Jan 29, 2026
volokluev
reviewed
Jan 29, 2026
snuba/query/processors/physical/boolean_tag_condition_processor.py
Outdated
Show resolved
Hide resolved
phacops
requested changes
Jan 29, 2026
| # aggregation is deprecated, it gets converted to conditional_aggregation | ||
| if state.get_int_config("aggregation_deprecation_enabled", 1): | ||
| for expr in in_msg.expressions: | ||
| assert expr.WhichOneof("expression") != "aggregation" |
Contributor
There was a problem hiding this comment.
We probably do not want an assert here. If we need to fail a query, we should return a proper exception with a 400 and a useful error message.
Member
Author
|
I switched the assertion to a Regarding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see getsentry/sentry-protos#170