Skip to content

fix(install): support case when repo is already cloned #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasboni merged 1 commit into from
Feb 18, 2026
Merged

fix(install): support case when repo is already cloned #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/plumber/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: plumber
description: Helm chart for Plumber
type: application
version: "1.0.3"
appVersion: "1.0.3"
version: "1.0.4"
appVersion: "1.0.4"
home: https://github.com/getplumber/platform/
maintainers:
- name: devpro
Expand Down
12 changes: 9 additions & 3 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,16 @@ if [ ! -f compose.yml ] || [ ! -f versions.env ]; then
exit 1
fi

git clone "$REPO_URL" "$REPO_DIR"
cd "$REPO_DIR"
if [ -d "$REPO_DIR" ]; then
echo "Directory ${REPO_DIR} already exists, updating..."
cd "$REPO_DIR"
git pull --ff-only || true
Copy link

@cursor cursor bot Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silent git pull failure shows misleading success message

Medium Severity

git pull --ff-only || true silently swallows all failures — including the case where the directory isn't actually a git repo, the remote is unreachable, or branches have diverged — and the script then prints a green "✓ Repository ready" message. The user has no indication the update failed and may proceed with stale or incorrect files. Since subsequent steps depend on repo contents (scripts/preflight.sh, versions.env), this can cause confusing downstream failures.

Additional Locations (1)

Fix in Cursor Fix in Web

else
git clone "$REPO_URL" "$REPO_DIR"
cd "$REPO_DIR"
fi
echo ""
echo -e "${GREEN}✓${NC} Repository cloned to $(pwd)"
echo -e "${GREEN}✓${NC} Repository ready at $(pwd)"
echo ""
fi

Expand Down