fix(install): support case when repo is already cloned#11
Conversation
PR SummaryLow Risk Overview Bumps the Helm chart Written by Cursor Bugbot for commit ff41c4d. This will update automatically on new commits. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| if [ -d "$REPO_DIR" ]; then | ||
| echo "Directory ${REPO_DIR} already exists, updating..." | ||
| cd "$REPO_DIR" | ||
| git pull --ff-only || true |
There was a problem hiding this comment.
Silent git pull failure shows misleading success message
Medium Severity
git pull --ff-only || true silently swallows all failures — including the case where the directory isn't actually a git repo, the remote is unreachable, or branches have diverged — and the script then prints a green "✓ Repository ready" message. The user has no indication the update failed and may proceed with stale or incorrect files. Since subsequent steps depend on repo contents (scripts/preflight.sh, versions.env), this can cause confusing downstream failures.


No description provided.