Skip to content

EDM-3079: Single container apps name is required #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
celdrake wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −7
Open

EDM-3079: Single container apps name is required #477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libs/i18n/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,6 @@
"Port mapping must be in format \"hostPort:containerPort\"": "Port mapping must be in format \"hostPort:containerPort\"",
"Invalid port values": "Invalid port values",
"Application name": "Application name",
"If not specified, the image name will be used. Application name must be unique.": "If not specified, the image name will be used. Application name must be unique.",
"Image": "Image",
"Provide a valid image reference": "Provide a valid image reference",
"Ports": "Ports",
Expand Down Expand Up @@ -418,6 +417,7 @@
"Inline": "Inline",
"Define application files directly in this interface (custom, one-off).": "Define application files directly in this interface (custom, one-off).",
"The unique identifier for this application.": "The unique identifier for this application.",
"If not specified, the image name will be used. Application name must be unique.": "If not specified, the image name will be used. Application name must be unique.",
"Application workloads": "Application workloads",
"Define the application workloads that shall run on the device.": "Define the application workloads that shall run on the device.",
"Configure containerized applications and services that will run on your fleet devices. You can deploy single containers, Quadlet applications for advanced container orchestration or inline applications with custom files.": "Configure containerized applications and services that will run on your fleet devices. You can deploy single containers, Quadlet applications for advanced container orchestration or inline applications with custom files.",
Expand Down
8 changes: 2 additions & 6 deletions libs/ui-components/src/components/Device/EditDeviceWizard/steps/ApplicationContainerForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,13 +154,9 @@ const ApplicationContainerForm = ({ index, isReadOnly }: { index: number; isRead

return (
<Grid hasGutter>
<FormGroupWithHelperText
label={t('Application name')}
content={t('If not specified, the image name will be used. Application name must be unique.')}
isRequired
>
<FormGroup label={t('Application name')} isRequired>
<TextField aria-label={t('Application name')} name={`${appFieldName}.name`} isDisabled={isReadOnly} />
</FormGroupWithHelperText>
</FormGroup>
<FormGroup label={t('Image')} isRequired>
<TextField
aria-label={t('Image')}
Expand Down