Skip to content

EDM-3079: Single container apps name is required#477

Open
celdrake wants to merge 1 commit intoflightctl:mainfrom
celdrake:EDM-3079-single-container-app-name
Open

EDM-3079: Single container apps name is required#477
celdrake wants to merge 1 commit intoflightctl:mainfrom
celdrake:EDM-3079-single-container-app-name

Conversation

@celdrake
Copy link
Collaborator

@celdrake celdrake commented Feb 4, 2026

For Single Container apps, there is no "image" field, therefore the application name is required.

Summary by CodeRabbit

  • Refactor
    • Simplified the Application name field in the device configuration wizard by removing supplementary helper text, now displaying as a required field with cleaner formatting.

@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

Walkthrough

A translation entry in the English locale file was relocated to a different section, and the Application name field UI component was simplified by replacing FormGroupWithHelperText with a plain FormGroup and removing helper text.

Changes

Cohort / File(s) Summary
Localization
libs/i18n/locales/en/translation.json
Translation entry for "If not specified, the image name will be used..." moved to a different section within the JSON structure.
Component Simplification
libs/ui-components/src/components/Device/EditDeviceWizard/steps/ApplicationContainerForm.tsx
Application name field wrapper changed from FormGroupWithHelperText to plain FormGroup with required attribute; helper text removed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and directly summarizes the main change: making the application name field required for single container apps, which aligns with both the PR description and the code modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant