Skip to content

remove #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xzrderek merged 1 commit into from
Dec 29, 2025
Merged

remove #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/chinook/langgraph/test_langgraph_chinook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import pytest

pytest.skip(
"Skipping Chinook langgraph integration tests (requires external services/credentials).",
allow_module_level=True,
)
Copy link

@cursor cursor bot Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unconditional skip disables tests even when credentials available

The pytest.skip() call unconditionally skips all tests at the module level, making the existing @pytest.mark.skipif decorator on test_langgraph_simple_query (which properly checks for FIREWORKS_API_KEY) completely ineffective. Tests will never run even when credentials are available and properly configured. This appears to be temporary code that was accidentally committed, as the proper conditional skip mechanism already exists in the test decorator.

Fix in Cursor Fix in Web


from eval_protocol.models import EvaluateResult, EvaluationRow, Message
from eval_protocol.pytest import evaluation_test

Expand Down
Loading