remove #390
Merged
remove #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| pytest.skip( | ||
| "Skipping Chinook langgraph integration tests (requires external services/credentials).", | ||
| allow_module_level=True, | ||
| ) |
There was a problem hiding this comment.
Unconditional skip disables tests even when credentials available
The pytest.skip() call unconditionally skips all tests at the module level, making the existing @pytest.mark.skipif decorator on test_langgraph_simple_query (which properly checks for FIREWORKS_API_KEY) completely ineffective. Tests will never run even when credentials are available and properly configured. This appears to be temporary code that was accidentally committed, as the proper conditional skip mechanism already exists in the test decorator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Testing changes
pytest.skip(...)intests/chinook/langgraph/test_langgraph_chinook.pyto skip langgraph integration tests that require external services/credentials.Written by Cursor Bugbot for commit d28c249. This will update automatically on new commits. Configure here.