Skip to content

Remove signal notify boilerplate for now #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pfleidi wants to merge 4 commits into from
Closed

Remove signal notify boilerplate for now #434

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c780808
Use signal.NotifyContext() instead of signal.Notify() boilerplat
pfleidi Feb 19, 2026
e63243b
Remove signal handling and simplify to Execute()
gtrrz-victor Feb 20, 2026
07990a6
Merge branch 'main' into signal-notifycontext
pfleidi Feb 20, 2026
dfba1ab
Merge branch 'main' into signal-notifycontext
Soph Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions cmd/entire/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,18 @@
package main

import (
"context"
"errors"
"fmt"
"os"
"os/signal"
"strings"
"syscall"

"github.com/entireio/cli/cmd/entire/cli"
"github.com/spf13/cobra"
)

func main() {
// Create context that cancels on interrupt
ctx, cancel := context.WithCancel(context.Background())

// Handle interrupt signals
sigChan := make(chan os.Signal, 1)
signal.Notify(sigChan, os.Interrupt, syscall.SIGTERM)
go func() {
<-sigChan
cancel()
}()

// Create and execute root command
rootCmd := cli.NewRootCmd()
err := rootCmd.ExecuteContext(ctx)
err := rootCmd.Execute()

if err != nil {
var silent *cli.SilentError
Expand All @@ -41,10 +26,8 @@ func main() {
fmt.Fprintln(rootCmd.OutOrStderr(), err)
}

cancel()
os.Exit(1)
}
cancel() // Cleanup on successful exit
}

func showSuggestion(cmd *cobra.Command, err error) {
Expand Down