Closed
Conversation
Entire-Checkpoint: 4d7e19fbfd1e
pfleidi
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies CLI shutdown handling by replacing the manual signal.Notify() + goroutine cancellation boilerplate with Go’s signal.NotifyContext(), keeping the root command execution cancelable via context.
Changes:
- Replace manual signal channel + goroutine cancellation with
signal.NotifyContext(...) - Keep context cancellation wired into
ExecuteContextfor graceful shutdown on Ctrl+C / SIGTERM
No command uses cmd.Context(), so the signal.NotifyContext setup was dead code. Switch from ExecuteContext to plain Execute. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Entire-Checkpoint: 579b31e91172
gtrrz-victor
approved these changes
Feb 20, 2026
pfleidi
changed the title
Author
|
I'm closing this PR in favor of adding plumbing to hand down the root context to the places that need it. I'll open a new PR for the new changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entire-Checkpoint: 4d7e19fbfd1e
Summary
This pull request simplifies the startup and shutdown logic in the
cmd/entire/main.gofile by removing interrupt signal handling and the use of context cancellation. The main function now directly executes the root command and handles errors without additional cleanup logic.This is mostly a stopgap solution for now until we have added consistent plumbing to forward the root context to the places using it.
Test plan