Skip to content

Added context kubectlpath configuration #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parasit wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added context kubectlpath configuration #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ausroller/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,15 @@ def read_config(self):
logging.error("Missing section {} in configuration file {}. Abort execution.".format(
section, self.configfile))
sys.exit(1)

# If kubectlpath is defined in context section use it instead of default one
logging.debug('Try to read context related kubectlpath config')
try:
self.contextkubectlpath = cp.get(self.context, 'kubectlpath')
Copy link

@hemarkus hemarkus Apr 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't create a member for this just use a local variable.

logging.debug('Context kubectlpath found ({})'.format(self.contextkubectlpath))
self.kubectlpath = self.contextkubectlpath
except:
Copy link

@hemarkus hemarkus Apr 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not catch every exception

logging.debug('No extra kubectlpath in context section')

if not self.kubectlpath:
logging.warn("Trying to use default 'kubectl' from PATH")
Expand Down