Added context kubectlpath configuration #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemarkus
suggested changes
Apr 26, 2017
hemarkus
left a comment
hemarkus
left a comment
There was a problem hiding this comment.
I like it, was also thinking about this :)
Anyway please write a commit message about what you did and why.
Also fix the two minor issues I found.
| # If kubectlpath is defined in context section use it instead of default one | ||
| logging.debug('Try to read context related kubectlpath config') | ||
| try: | ||
| self.contextkubectlpath = cp.get(self.context, 'kubectlpath') |
There was a problem hiding this comment.
Don't create a member for this just use a local variable.
| self.contextkubectlpath = cp.get(self.context, 'kubectlpath') | ||
| logging.debug('Context kubectlpath found ({})'.format(self.contextkubectlpath)) | ||
| self.kubectlpath = self.contextkubectlpath | ||
| except: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when we use different server version better use corresponding kubectl version.