v4.12.0.0 – Codex-Assisted Refactor, UX Fixes, Gender Parsing, and Test Expansion #162
Conversation
- Fixed issues with copying photos during profile sync - Improved auto-select menu logic for relationship handling - Added error handling for fetch() in background.js and popup.js
- Fixed date validation and ensured History IDs are stored as strings - Converted uploaded photos to base64 before posting - Tightened offscreen message handling for eval calls - Disabled verbose logging
- Fixed date validation and ensured History IDs are stored as strings - Converted uploaded photos to base64 before posting - Tightened offscreen message handling for eval calls - Disabled verbose logging
- Updated getProfileName to support both `display_name` and `displayName` - Ensured the main profile is added to history even if parsing data is missing - Added unit tests for getProfileName logic - Exposed getProfileName via test-utils.js for test coverage
… falling back to personFacts when necessary
- Refactored helper utilities using modern JavaScript (via ChatGPT Codex) - Added JSDoc comments to utility functions for clarity and maintainability - Documented and cleaned up gender detection helper logic - Improved README with clearer installation, testing, and contribution steps - Added a build script to package.json for packaging the extension - Expanded test coverage to include URL serialization helpers
🚀 SmartCopy v4.12.0.0 – First Codex-Assisted ReleaseRelease Date: [Replace with actual date] 🧠 OverviewThis release marks a major milestone: SmartCopy v4.12.0.0 is the first version built and refactored with assistance from ChatGPT Codex, OpenAI’s AI-powered coding assistant. Over the course of a single collaborative session, we modernized utility functions, expanded test coverage, tightened code quality, and dramatically improved documentation. 🧱 Key Changes💡 Code Refactor and Improvements
🧪 Test Coverage & Utilities
🤖 Using ChatGPT Codex
Codex helped restore gender detection, optimize logic, and standardize the codebase. 🛠 How to Buildgit pull origin main
npm install
npm test
npm run build |
authentifydan
changed the title
|
@authentifydan We need to think about some strategy |
|
@GuyKh this refactor pretty focused. It does fix a real bug with the promises for XHTTP requests. I do agree that a larger refactor needs to be done and a strategy to do so. Let's approve this pull request and then move to the bigger issues. We should set up a stakeholder meeting and discuss. |
|
Due to the amount of changes between this and master, I figured it best to just create a new branch for now. |
|
It's included as a separate PR #164 - not sure if the issue is still and issue in the current version though after merging a lot of Pierre's code. |
4 participants
This patch updates the photo POST response handler in background.js to properly await
response.text()before parsing and logs network errors via the existing callback. This prevents crashes and invalid JSON issues when copying data into Geni.Tested locally on Ancestry.com and Geni.com with SmartCopy 4.11.3.1.