Monitor GTK4 port #443
Merged
Monitor GTK4 port #443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
danirabbit
requested changes
Jul 11, 2025
danirabbit
reviewed
Jul 11, 2025
Member
Author
|
Looks like sidebar is not showing up on main |
Member
Author
|
Looks like ctrl-e and ctrl-k not working |
Member
I'm seeing the sidebar on both here? |
danirabbit
reviewed
Oct 1, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
danirabbit
approved these changes
Oct 3, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Still don't love adding CSS changes here, but overall I think this is okay and we can continue to iterate in main :)
Member
Author
|
Can't rebase - still has conflicts 🤨 |
Member
|
@stsdc yes I would definitely recommend squash merge in the web UI over trying to manually rebase this |
stsdc
commented
Oct 3, 2025
Comment on lines
+31
to
+32
| height_request = 120, | ||
| valign = START |
Member
Author
There was a problem hiding this comment.
Yeah, I had to fix alignment and height, since SystemStorageView doesn't use WidgetResource.
danirabbit
requested changes
Oct 3, 2025
danirabbit
approved these changes
Oct 3, 2025
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Builds in CI, so lets' go 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Indicator build is disabled for now. Waiting for Wingpanel GTK4 port to finish.Note: Deprecation warnings connected to TreeView, TreeIter, TreeViewColumn, CellRendererPixbuf are out of scope for this PR.
To Fix:
button_more_infoGLib-GObject-CRITICAL's