Skip to content

Fix random chat stream errors #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reakaleek merged 2 commits into from
Jan 27, 2026
+6 −4
Merged

Fix random chat stream errors #2573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
414cc33
Fix random chat stream errors
reakaleek Jan 27, 2026
6024437
Fix test
reakaleek Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...pi/Elastic.Documentation.Api.Infrastructure/Adapters/AskAi/LlmGatewayStreamTransformer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,10 @@ protected override async Task ProcessStreamAsync(PipeReader reader, PipeWriter w
"tool_call" when messageData.TryGetProperty("toolCalls", out var toolCalls) =>
TransformToolCall(id, timestamp, toolCalls),

"tool_message" when messageData.TryGetProperty("toolCallId", out var toolCallId)
&& messageData.TryGetProperty("result", out var result) =>
new AskAiEvent.ToolResult(id, timestamp, toolCallId.GetString()!, result.GetString()!),
// Frontend only uses tool_result to show "Analyzing..." status - result content not displayed
// Skip sending the large payload (~30KB) to prevent CloudFront OAC buffering issues
"tool_message" when messageData.TryGetProperty("toolCallId", out var toolCallId) =>
new AskAiEvent.ToolResult(id, timestamp, toolCallId.GetString()!, ""),

"agent_end" =>
new AskAiEvent.ConversationEnd(id, timestamp),
Expand Down
3 changes: 2 additions & 1 deletion ...s/Elastic.Documentation.Api.Infrastructure.Tests/Adapters/AskAi/StreamTransformerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,8 @@ public async Task TransformAsyncWithRealLlmGatewayPayloadParsesAllEventTypes()
events[4].Should().BeOfType<AskAiEvent.ToolResult>();
var toolResult = events[4] as AskAiEvent.ToolResult;
toolResult!.ToolCallId.Should().Be("tool1");
toolResult.Result.Should().Contain("Found 10 docs");
// Result is intentionally empty - payload stripped to prevent CloudFront OAC buffering issues
toolResult.Result.Should().BeEmpty();

// Event 6: ai_message
events[5].Should().BeOfType<AskAiEvent.MessageComplete>();
Expand Down
Loading