Fix random chat stream errors #2573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| toolResult!.ToolCallId.Should().Be("tool1"); | ||
| toolResult.Result.Should().Contain("Found 10 docs"); | ||
| // Result is intentionally empty - payload stripped to prevent CloudFront OAC buffering issues | ||
| toolResult.Result.Should().BeEmpty(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was happening
The AI chat would sometimes stop working in the middle of a conversation. Users saw a network error in their browser, even though the server processed everything correctly.
Why it was happening
When the AI searches for documents, we were sending the full search results (about 30KB of data) back to the browser. This large amount of data was causing problems with CloudFront (our content delivery service), which would sometimes close the connection unexpectedly.
What we changed
We now send an empty result instead of the full search data.
This works because:
Result