lb: Match library functions #2037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Report for GALE01 (21db498 - 6eb2edf)📈 Matched code: 47.91% (+0.01%, +380 bytes) ✅ 5 new matches
📈 4 improvements in unmatched functions
|
ribbanya
requested changes
Dec 30, 2025
2 tasks
itsgrimetime
force-pushed
the
batch/lb-20241230
branch
from
00515d9 to
ea248bf
Compare
- lbAudioAx_800265C4 (100%) - fn_800263B4 (100%) - lbMthp8001F890 (97.9%) - lbMthp8001F928 (99.4%) - lbRefract_800225D4 (100%) - lbRefract_80022560 (100%) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Partially match fn_800204C8 in lbbgflash.c with 91.9% match. Remaining differences are branch structure (bge+b vs inverted blt). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The previous commit incorrectly set lbrefract.c to Matching, but the file is missing stub markers for unimplemented functions (lbRefract_800222A4, lbRefract_80022560, etc.), causing linker errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Required for HSD_CObjGetProjectionType prototype when building with --require-protos. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The 91.9% match was causing symbol shift in the linked binary. Reverted to stub for now - can be fixed by /decomp-fixup later. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The previous change reordered variable declarations which made the match worse (90.90% -> 90.43%). Reverting to original order. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
These files have functions that aren't 100% matched yet, so they need to remain NonMatching to avoid link failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
itsgrimetime
force-pushed
the
batch/lb-20241230
branch
from
ea248bf to
e12fa1d
Compare
- Change lbAudioAx_800265C4 return type from int to bool - Use M2C_FIELD macro for raw field access - Use true/false instead of 1/0 for bool returns 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
itsgrimetime
force-pushed
the
batch/lb-20241230
branch
from
e12fa1d to
a222370
Compare
ribbanya
approved these changes
Jan 5, 2026
itsgrimetime
added a commit
to itsgrimetime/melee
that referenced
this pull request
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lbAudioAx,lbMthp,lbRefractfunctions (100%)lbRefract_8002247C(100%)fn_800204C8(91.9%)lb_8001C4A8(100%)lbSnap_8001DF6C(100%)Test plan
🤖 Generated with Claude Code