lb: Match audio, snap, and refract functions #2043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lbAudioAx_800265C4 (100%) - fn_800263B4 (100%) - lbMthp8001F890 (97.9%) - lbMthp8001F928 (99.4%) - lbRefract_800225D4 (100%) - lbRefract_80022560 (100%) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Partially match fn_800204C8 in lbbgflash.c with 91.9% match. Remaining differences are branch structure (bge+b vs inverted blt). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The previous commit incorrectly set lbrefract.c to Matching, but the file is missing stub markers for unimplemented functions (lbRefract_800222A4, lbRefract_80022560, etc.), causing linker errors. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Required for HSD_CObjGetProjectionType prototype when building with --require-protos. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Change lbAudioAx_800265C4 return type from int to bool - Use M2C_FIELD macro for raw field access - Use true/false instead of 1/0 for bool returns 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Report for GALE01 (acec241 - 86894da)📈 Matched code: 47.66% (+0.00%, +192 bytes) ✅ 2 new matches
📈 5 improvements in unmatched functions
📉 1 regression in unmatched functions
|
- Remove trailing whitespace in lbbgflash.c and lbrefract.c - Revert lbcardnew.c to NonMatching (stub for lb_8001B14C causes link failure) - Revert lbsnap.c to NonMatching (function alignment mismatch) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
lbAudioAx,lbMthp,lbRefractfunctionslbRefract_8002247C(100%)fn_800204C8(91.9%)lb_8001C4A8(100%)lbSnap_8001DF6C(100%)8 commits covering audio, snapshot, and refraction utilities in the lb module.
Test plan
🤖 Generated with Claude Code