Skip to content

Fix source/target device address mismatch in pccb2_portopen cast #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dominicletz merged 3 commits into from
Jan 15, 2026
Merged

Fix source/target device address mismatch in pccb2_portopen cast #9

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1c16e3
Initial plan
Copilot Jan 9, 2026
07a6dfe
Fix: Replace target_device_address with source_device_address in pccb…
Copilot Jan 9, 2026
b270b6a
Update documentation to match actual pccb2_portopen signature
Copilot Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/network/port_manager.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ defmodule Network.PortManager do

1. Edge A send "portopen" via socket
2. Client A receives "portopen" and calls PortManager.request_portopen -- BLOCKING
3. Client B receives cast: {:pccb2_portopen, worker_pid, portname, physical_port, source_device_address, target_device_address, flags}
3. Client B receives cast: {:pccb2_portopen, portname, physical_port, source_device_address, flags}
4. Client B send "portopen" via socket to Edge B
5. Client B receives "ack" or "deny" from Edge B
6. Client B calls PortManager.confirm_portopen or PortManager.deny_portopen
Expand All @@ -25,7 +25,7 @@ defmodule Network.PortManager do

Port GenServers who are sender/receiver have to implement these calls:application

- handle_cast({:pccb2_portopen, worker_pid, portname, physical_port, source_device_address, target_device_address, flags}, state)
- handle_cast({:pccb2_portopen, portname, physical_port, source_device_address, flags}, state)
- handle_cast({:pccb2_portclose, physical_port}, state)


Expand Down Expand Up @@ -193,7 +193,7 @@ defmodule Network.PortManager do
{:ok, physical_port} ->
GenServer.cast(
target_pid,
{:pccb2_portopen, msg.portname, physical_port, target_device_address, msg.flags}
{:pccb2_portopen, msg.portname, physical_port, source_device_address, msg.flags}
)

GenServer.reply(from, {:ok, physical_port})
Expand Down