Fix source/target device address mismatch in pccb2_portopen cast

[Copilot]

The pccb2_portopen cast was incorrectly passing target_device_address instead of source_device_address, causing a mismatch with the receiver's expected signature.

Changes

• Fixed GenServer.cast at line 196: Changed fourth parameter from target_device_address to source_device_address to match the handler signature in edge_v2.ex
• Updated module documentation: Corrected the documented function signatures at lines 19 and 28 to reflect actual implementation (5 parameters, not 6)

Context

The spawn_worker function sends a port open message to the target process:

# Before
GenServer.cast(
  target_pid,
  {:pccb2_portopen, msg.portname, physical_port, target_device_address, msg.flags}
)

# After  
GenServer.cast(
  target_pid,
  {:pccb2_portopen, msg.portname, physical_port, source_device_address, msg.flags}
)

This aligns with the receiver in edge_v2.ex which expects source_device_address to send back to the originating device.

Original prompt

The function call at line 196 of lib/network/port_manager.ex currently passes target_device_address in the tuple {:pccb2_portopen, msg.portname, physical_port, target_device_address, msg.flags}. As per the requirement, source_port_address should be passed instead. This requires modifying the code to replace target_device_address with source_port_address in this specific function call. Before making this change, ensure that source_port_address is defined and available in the current scope of this function. If not, retrieve it or compute it as needed to ensure the proper functionality of the code after the fix.

This pull request was created from Copilot chat.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[cursor]

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on February 10.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.