Skip to content

fix: improve mobile layout for provider list #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NieiR wants to merge 1 commit into from
Closed

fix: improve mobile layout for provider list #614

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 57 additions & 4 deletions src/app/[locale]/settings/providers/_components/provider-rich-list-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ export function ProviderRichListItem({

return (
<>
<div className="flex items-center gap-4 py-3 px-4 border-b hover:bg-muted/50 transition-colors">
<div className="flex flex-wrap items-start gap-2 py-3 px-4 border-b hover:bg-muted/50 transition-colors md:flex-nowrap md:items-center md:gap-4">
{/* 左侧：状态和类型图标 */}
<div className="flex items-center gap-2">
{/* 启用状态指示器 */}
Expand All @@ -366,7 +366,7 @@ export function ProviderRichListItem({
</div>

{/* 中间：名称、URL、官网、tag、熔断状态 */}
<div className="flex-1 min-w-0">
<div className="flex-1 min-w-0 w-full md:w-auto">
<div className="flex items-center gap-2 flex-wrap">
{/* Favicon */}
{provider.faviconUrl && (
Expand All @@ -382,7 +382,7 @@ export function ProviderRichListItem({
)}

{/* 名称 */}
<span className="font-semibold truncate">{provider.name}</span>
<span className="font-semibold md:truncate">{provider.name}</span>

{/* Group Tags (supports comma-separated values) */}
{(provider.groupTag
Expand Down Expand Up @@ -556,8 +556,61 @@ export function ProviderRichListItem({
)}
</div>

{/* 移动端：指标快速编辑 */}
<div className="grid grid-cols-3 gap-4 text-center w-full md:hidden">
<div>
<div className="text-xs text-muted-foreground">{tList("priority")}</div>
<div className="font-medium">
{canEdit ? (
<InlineEditPopover
value={provider.priority}
label={tInline("priorityLabel")}
type="integer"
validator={validatePriority}
onSave={handleSavePriority}
/>
) : (
<span>{provider.priority}</span>
)}
</div>
</div>
<div>
<div className="text-xs text-muted-foreground">{tList("weight")}</div>
<div className="font-medium">
{canEdit ? (
<InlineEditPopover
value={provider.weight}
label={tInline("weightLabel")}
type="integer"
validator={validateWeight}
onSave={handleSaveWeight}
/>
) : (
<span>{provider.weight}</span>
)}
</div>
</div>
<div>
<div className="text-xs text-muted-foreground">{tList("costMultiplier")}</div>
<div className="font-medium">
{canEdit ? (
<InlineEditPopover
value={provider.costMultiplier}
label={tInline("costMultiplierLabel")}
validator={validateCostMultiplier}
onSave={handleSaveCostMultiplier}
suffix="x"
type="number"
/>
) : (
<span>{provider.costMultiplier}x</span>
)}
</div>
</div>
</div>
Comment on lines +560 to +610
Copy link

@gemini-code-assist gemini-code-assist bot Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This block of code for mobile metrics editing is identical to the desktop version (lines 482-532). To improve maintainability and reduce duplication, you can extract this JSX into a local component.

For example, you could define a MetricsEditor component inside ProviderRichListItem:

const MetricsEditor = () => (
  <>
    <div>
      <div className="text-xs text-muted-foreground">{tList("priority")}</div>
      <div className="font-medium">
        {canEdit ? (
          <InlineEditPopover
            value={provider.priority}
            label={tInline("priorityLabel")}
            type="integer"
            validator={validatePriority}
            onSave={handleSavePriority}
          />
        ) : (
          <span>{provider.priority}</span>
        )}
      </div>
    </div>
    <div>
      <div className="text-xs text-muted-foreground">{tList("weight")}</div>
      <div className="font-medium">
        {canEdit ? (
          <InlineEditPopover
            value={provider.weight}
            label={tInline("weightLabel")}
            type="integer"
            validator={validateWeight}
            onSave={handleSaveWeight}
          />
        ) : (
          <span>{provider.weight}</span>
        )}
      </div>
    </div>
    <div>
      <div className="text-xs text-muted-foreground">{tList("costMultiplier")}</div>
      <div className="font-medium">
        {canEdit ? (
          <InlineEditPopover
            value={provider.costMultiplier}
            label={tInline("costMultiplierLabel")}
            validator={validateCostMultiplier}
            onSave={handleSaveCostMultiplier}
            suffix="x"
            type="number"
          />
        ) : (
          <span>{provider.costMultiplier}x</span>
        )}
      </div>
    </div>
  </>
);

You can then use <MetricsEditor /> to replace the content of this div and the one for the desktop view, making the code cleaner and easier to maintain.


{/* 操作按钮 */}
<div className="flex items-center gap-1 flex-shrink-0">
<div className="flex items-center gap-3 flex-shrink-0 w-full justify-end pt-2 border-t border-border/30 md:gap-1 md:w-auto md:pt-0 md:border-t-0">
{/* 启用/禁用切换 */}
{canEdit && (
<Switch
Expand Down
Loading