Fix: compiler issue with vector<bool> in Field#334
Merged
Conversation
dglaeser
changed the title
Field
|
The following performance differences (this branch vs target branch) have been measured: |
|
The following performance differences (this branch vs target branch) have been measured: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After rebuilding the docker images, a compiler error emerged because of the serialization mechanism of fields over
vector<bool>.Newer compilers seem to take it again, but nevertheless, it was reworked such that it now also works with the compilers we use in our current test images.
Besides this, the new test image build yielded a new vtk version, where the data model for parallel grids read from hdf5 files has been changed. The test script has been adapted to handle these changes. The change is rather "hacky". If more such changes occur in the future we will have to properly refactor the test script.