Skip to content

Comments

feat(test): support pyvtk9.5#332

Closed
dglaeser wants to merge 1 commit intomainfrom
feature/support-vtk-9.5
Closed

feat(test): support pyvtk9.5#332
dglaeser wants to merge 1 commit intomainfrom
feature/support-vtk-9.5

Conversation

@dglaeser
Copy link
Owner

@dglaeser dglaeser commented Jan 27, 2026

There were some changes in the python api of vtk9.5 that require us to adapt the test scripts. Also, I noticed that some compilers complain about our generic data copy code using std::ranges with std::vector<bool> (support for the latter was introduced in #291).

Newer compilers seem to be less picky, there have possibly been fixes to std::ranges or std::vector<bool> in the standard and/or implementations. In this PR, the code has been changed to fall back to std::copy. It shouldn't come with any performance penalty.

@github-actions
Copy link

The following performance differences (this branch vs target branch) have been measured:
Relative deviation of average for 'app_raw': -0.44%
Relative deviation of average for 'inline_b64': 0.02%
Relative deviation of average for 'app_b64': -0.21%
Relative deviation of average for 'ascii': -0.37%

@dglaeser dglaeser force-pushed the feature/support-vtk-9.5 branch from bf893c2 to 757de2b Compare January 27, 2026 11:33
@github-actions
Copy link

The following performance differences (this branch vs target branch) have been measured:
Relative deviation of average for 'app_b64': 0.29%
Relative deviation of average for 'ascii': 1.00%
Relative deviation of average for 'app_raw': 0.13%
Relative deviation of average for 'inline_b64': -0.29%

@dglaeser dglaeser force-pushed the feature/support-vtk-9.5 branch from 757de2b to e9dc7c0 Compare January 27, 2026 18:01
@github-actions
Copy link

The following performance differences (this branch vs target branch) have been measured:
Relative deviation of average for 'ascii': 0.14%
Relative deviation of average for 'app_b64': -0.24%
Relative deviation of average for 'app_raw': 0.87%
Relative deviation of average for 'inline_b64': -0.42%

@dglaeser
Copy link
Owner Author

Closing this as superseded by #334

@dglaeser dglaeser closed this Jan 29, 2026
@dglaeser dglaeser deleted the feature/support-vtk-9.5 branch January 29, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant