Use the cargo-supplied RUSTC environment variable.#11
Open
cfrantz wants to merge 1 commit intodcuddeback:masterfrom
Open
Use the cargo-supplied RUSTC environment variable.#11cfrantz wants to merge 1 commit intodcuddeback:masterfrom
cfrantz wants to merge 1 commit intodcuddeback:masterfrom
Conversation
When executing build scripts, [cargo sets several environment variables](https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-build-scripts). Use the cargo-supplied value for `RUSTC`. This _also_ allows `libudev-sys` to be build by [bazel](https://bazel.build) using rules created by `cargo raze`. Signed-off-by: Chris Frantz <cfrantz@google.com>
cfrantz
added a commit
to cfrantz/opentitan
that referenced
this pull request
Dec 10, 2021
The libudev-sys crate invokes the compiler directly rather than via the cargo (and bazel) supplied `RUSTC` environment variable. This causes the library to fail when building under bazel. This patch fixes the libudev-sys crate to invoke the compiler via the `RUSTC` variable. This is the same patch as the [PR](dcuddeback/libudev-sys#11) sent to libudev-sys. Signed-off-by: Chris Frantz <cfrantz@google.com>
drewmacrae
pushed a commit
to drewmacrae/opentitan
that referenced
this pull request
Dec 11, 2021
The libudev-sys crate invokes the compiler directly rather than via the cargo (and bazel) supplied `RUSTC` environment variable. This causes the library to fail when building under bazel. This patch fixes the libudev-sys crate to invoke the compiler via the `RUSTC` variable. This is the same patch as the [PR](dcuddeback/libudev-sys#11) sent to libudev-sys. Signed-off-by: Chris Frantz <cfrantz@google.com>
cfrantz
added a commit
to lowRISC/opentitan
that referenced
this pull request
Dec 13, 2021
The libudev-sys crate invokes the compiler directly rather than via the cargo (and bazel) supplied `RUSTC` environment variable. This causes the library to fail when building under bazel. This patch fixes the libudev-sys crate to invoke the compiler via the `RUSTC` variable. This is the same patch as the [PR](dcuddeback/libudev-sys#11) sent to libudev-sys. Signed-off-by: Chris Frantz <cfrantz@google.com>
|
+1. Thanks for providing this patch @cfrantz |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When executing build scripts, cargo sets several environment variables.
Use the cargo-supplied value for
RUSTC.This also allows
libudev-systo be build by bazelusing rules created by
cargo raze.Signed-off-by: Chris Frantz cfrantz@google.com