[bazel] Fix rust libudev-sys to build under bazel#9648
Merged
cfrantz merged 1 commit intolowRISC:masterfrom Dec 13, 2021
Merged
[bazel] Fix rust libudev-sys to build under bazel#9648cfrantz merged 1 commit intolowRISC:masterfrom
cfrantz merged 1 commit intolowRISC:masterfrom
Conversation
The libudev-sys crate invokes the compiler directly rather than via the cargo (and bazel) supplied `RUSTC` environment variable. This causes the library to fail when building under bazel. This patch fixes the libudev-sys crate to invoke the compiler via the `RUSTC` variable. This is the same patch as the [PR](dcuddeback/libudev-sys#11) sent to libudev-sys. Signed-off-by: Chris Frantz <cfrantz@google.com>
drewmacrae
approved these changes
Dec 11, 2021
Contributor
drewmacrae
left a comment
drewmacrae
left a comment
There was a problem hiding this comment.
SGTM, We'll revert this when it gets accepted upstream and we update libudev-sys
Contributor
|
I've cherry-picked and am using this to build and test the smoketests. |
mcy
approved these changes
Dec 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libudev-sys crate invokes the compiler directly rather than via the
cargo (and bazel) supplied
RUSTCenvironment variable. This causes thelibrary to fail when building under bazel. This patch fixes the
libudev-sys crate to invoke the compiler via the
RUSTCvariable.This is the same patch as the PR
sent to libudev-sys.
Signed-off-by: Chris Frantz cfrantz@google.com