Conversation
|
Hi @ZanyMonk Thank you for your valuable contribution to the project. I have no problem to merge your PR, however, I wanted to warn you about limited usefulness of this change: since Request Baskets service does not implement HTTPS protocol and certificates handling (on purpose, see #52), the recommended way to run the service is behind a proxy that support HTTPS, e.g. nginx. In this case the You can get more insight and detailed explanation in this Stack Overflow answer: https://stackoverflow.com/a/27235620/2288384 Ideally the logic has to be extended and take into consideration the following HTTP request headers:
Would you prefer to extend your PR? Otherwise I can merge it AS IS. Cheers, |
|
Oh I didn't know about this issue. Alright I'll come up with a better solution. Thank you for your quick and detailed answer. |
Add the client IP (
http.Request.RemoteAddr) in the response "description".