Conversation
|
Hi, This PR is trying to address the issue reported here: #61 See my comment on the issue: unfortunately, Go developers decided to swallow the Your PR solves the issue for a subset of the cases and can mislead a client about true value of Given the fact that in most of the cases the Request Baskets service would run behind the proxy in order to gain HTTPS capabilities, the suggested logic for completing the Host header might be entirely incorrect. I'll try to run some tests to see how the logic behaves when a service is behind proxy, and will report my findings. Cheers, |
|
Another observation: the current implementation may actually break the request forwarding logic: I'm not really sure how the I would at least extend the headers cleanup logic and remove the |
Add the
Hostheader back into the request headers.