Skip to content

virtio/console: cols/rows order match the specs #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slp merged 1 commit into from
Feb 3, 2026
+3 −3
Merged

virtio/console: cols/rows order match the specs #522

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/devices/src/virtio/console/console_control.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@ unsafe impl ByteValued for VirtioConsoleControl {}
#[derive(Copy, Clone, Debug, Default)]
#[repr(C, packed)]
pub struct VirtioConsoleResize {
// NOTE: the order of these fields in the actual kernel implementation and in the spec are swapped,
// we follow the order in the kernel to get it working correctly
pub rows: u16,
// NOTE: the order of these fields in older Linux kernels and in the spec were swapped.
// Linux changed it in commit 5326ab737a47 to match the specs.
pub cols: u16,
pub rows: u16,
}

// Safe because it only has data and has no implicit padding.
Expand Down
Loading