virtio/console: cols/rows order match the specs #522
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For many years, the Linux kernel implemented the order of cols and rows swapped with respect of the specifications. In commit 5326ab737a47 it was changed to match the specs. There's no good way to address this. You either get a working virtio-console on newer kernels or on older kernels, but never on both. Making this configurable via the API would just mean dumping the burden onto the users. Fedora 43 and libkrunfw 5.2.0 already ship with a kernel with a "fixed" virtio-console, so let's follow suit and use the spec's order here too. Signed-off-by: Sergio Lopez <slp@redhat.com>
slp
requested review from
MatiasVara,
jakecorrenti,
mtjhrc and
tylerfanelli
as code owners
mtjhrc
approved these changes
Feb 2, 2026
Collaborator
mtjhrc
left a comment
mtjhrc
left a comment
There was a problem hiding this comment.
LGTM!
Since it looks like this is also being changed in all kernel releases (not just a change in a new kernel version), that is strongly in favor of just changing this on the libkrun side too, without user having to configure this.
Making this configurable via the API would just mean dumping the burden onto the users.
I agree in the sense that, If we wanted a configurable API, we should default to the "fixed" order at this point. (we could have an API to enable the non-spec-compliant order, but let's not bother since we don't need it currently).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For many years, the Linux kernel implemented the order of cols and rows swapped with respect of the specifications. In commit 5326ab737a47 it was changed to match the specs.
There's no good way to address this. You either get a working virtio-console on newer kernels or on older kernels, but never on both. Making this configurable via the API would just mean dumping the burden onto the users.
Fedora 43 and libkrunfw 5.2.0 already ship with a kernel with a "fixed" virtio-console, so let's follow suit and use the spec's order here too.