V9.0.5/service update #13
Conversation
WalkthroughThis update increments dependency versions across multiple package management files, updates Dockerfile build configuration to use a dynamic NGINX version argument, revises CI/CD workflow action versions, and refreshes release notes and changelogs for several packages. Test environment Docker image tags are also updated. Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Docker Build
participant NGINX Image Registry
Developer->>Docker Build: Build Docker image with NGINX_VERSION arg
Docker Build->>NGINX Image Registry: Pull nginx:${NGINX_VERSION}-alpine
NGINX Image Registry-->>Docker Build: Return nginx image
Docker Build-->>Developer: Build completes with specified nginx version
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.docfx/Dockerfile.docfx (2)
1-4: Nice parameterisation – small tweak keeps multi-stage builds consistentIntroducing
ARG NGINX_VERSIONis great. For clarity and cache-friendliness, add a secondARG NGINX_VERSIONjust before the finalFROMso the value is visible in that stage’s build context:+ARG NGINX_VERSION FROM nginx:${NGINX_VERSION} AS finalDocker will still reuse the global arg, but redeclaring is a common pattern and avoids “unused ARG” lint warnings.
13-13: Preserve explicit architecture targeting in the final stageThe base stage keeps
--platform=$BUILDPLATFORM, but the final stage drops a platform hint. If you rely on multi-arch images (e.g., arm64 runners), consider mirroring the option:-FROM nginx:${NGINX_VERSION} AS final +FROM --platform=$TARGETPLATFORM nginx:${NGINX_VERSION} AS finalThis ensures the produced image matches the requested target platform during cross-compilation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
.docfx/Dockerfile.docfx(2 hunks).github/workflows/pipelines.yml(2 hunks).nuget/Codebelt.Extensions.AspNetCore.Mvc.Formatters.Newtonsoft.Json/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.AspNetCore.Newtonsoft.Json/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.Newtonsoft.Json.App/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.Newtonsoft.Json/PackageReleaseNotes.txt(1 hunks)CHANGELOG.md(1 hunks)Directory.Packages.props(2 hunks)testenvironments.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
- GitHub Check: call-test (ubuntu-24.04, Release) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug) / 🧪 Test
- GitHub Check: call-test (windows-2022, Release) / 🧪 Test
- GitHub Check: call-pack (Release) / 📦 Pack
- GitHub Check: call-pack (Debug) / 📦 Pack
🔇 Additional comments (8)
testenvironments.json (1)
12-12: Verify that the new test-runner image tag exists and is publicly availableThe tag was bumped to
net8.0.412-9.0.302. Please confirm the image has been pushed to Docker Hub/GAR; otherwise the CI matrix will fail when it tries to pull the runner..github/workflows/pipelines.yml (1)
67-67: Good to track latest reusable workflows – double-check breaking-change notesJumping from
v1tov2for both SonarCloud and CodeQL is usually safe, but these major bumps occasionally deprecate inputs/outputs. Scan the release notes to confirm that:
• output names consumed downstream (needs.*.outputs.*) are unchanged
• new permission requirements are satisfied.No action required if nothing changed.
Also applies to: 85-85
CHANGELOG.md (1)
10-13: Changelog entry looks goodEntry is concise and follows the existing style.
.nuget/Codebelt.Extensions.AspNetCore.Newtonsoft.Json/PackageReleaseNotes.txt (1)
1-6: Release notes updated correctlyVersion header and dependency note align with the changelog.
.nuget/Codebelt.Extensions.AspNetCore.Mvc.Formatters.Newtonsoft.Json/PackageReleaseNotes.txt (1)
1-6: Release-notes entry is clear and consistent
The new 9.0.5 section follows the established format and accurately communicates the dependency-upgrade scope. No further action required..nuget/Codebelt.Extensions.Newtonsoft.Json.App/PackageReleaseNotes.txt (1)
1-6: Changelog addition looks correct
Version header, availability statement, and ALM note match the conventions used in prior entries..nuget/Codebelt.Extensions.Newtonsoft.Json/PackageReleaseNotes.txt (1)
1-6: Entry aligns with related packages
The 9.0.5 notice keeps wording and formatting in sync with sibling packages. No issues spotted.Directory.Packages.props (1)
27-31: Cross-TFM consistency check for ASP.NET Core NewtonsoftJson
You raisedMicrosoft.AspNetCore.Mvc.NewtonsoftJsonto 9.0.7 for net9 and 8.0.18 for net8. Double-check that:
- No net7 or earlier targets still reference the older line.
- The chosen patch releases are the latest available hotfixes for each TFM at publish time.
| <PackageVersion Include="Codebelt.Extensions.Xunit" Version="10.0.4" /> | ||
| <PackageVersion Include="Codebelt.Extensions.Xunit.App" Version="10.0.4" /> | ||
| <PackageVersion Include="Cuemon.AspNetCore.Mvc" Version="9.0.7" /> | ||
| <PackageVersion Include="Cuemon.Core" Version="9.0.7" /> | ||
| <PackageVersion Include="Cuemon.Extensions.AspNetCore" Version="9.0.7" /> | ||
| <PackageVersion Include="Cuemon.Extensions.AspNetCore.Authentication" Version="9.0.7" /> | ||
| <PackageVersion Include="Cuemon.Extensions.AspNetCore.Mvc" Version="9.0.7" /> | ||
| <PackageVersion Include="Cuemon.Extensions.Core" Version="9.0.7" /> | ||
| <PackageVersion Include="Cuemon.Extensions.IO" Version="9.0.7" /> | ||
| <PackageVersion Include="Cuemon.IO" Version="9.0.7" /> |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Confirm NuGet availability of the bumped versions
All Codebelt and Cuemon packages were lifted to new patch versions. NuGet publishing sometimes lags the PR merge, so it’s worth validating that every referenced version is already on nuget.org to avoid CI/restore failures.
🏁 Script executed:
#!/usr/bin/env bash
# Validate that every newly-bumped package@version actually exists on NuGet
pkgs=(
"Codebelt.Extensions.Xunit:10.0.4"
"Codebelt.Extensions.Xunit.App:10.0.4"
"Cuemon.AspNetCore.Mvc:9.0.7"
"Cuemon.Core:9.0.7"
"Cuemon.Extensions.AspNetCore:9.0.7"
"Cuemon.Extensions.AspNetCore.Authentication:9.0.7"
"Cuemon.Extensions.AspNetCore.Mvc:9.0.7"
"Cuemon.Extensions.Core:9.0.7"
"Cuemon.Extensions.IO:9.0.7"
"Cuemon.IO:9.0.7"
)
for pv in "${pkgs[@]}"; do
IFS=: read -r name ver <<<"$pv"
url="https://api.nuget.org/v3-flatcontainer/$(echo "$name" | tr '[:upper:]' '[:lower:]')/${ver}/$name.nuspec"
code=$(curl -s -o /dev/null -w "%{http_code}" "$url")
[[ "$code" == "200" ]] && echo "✔ $name $ver found" || echo "✖ $name $ver NOT FOUND"
doneLength of output: 5318
🚨 Bumped package versions not yet published on NuGet
The following packages referenced in Directory.Packages.props (lines 6–15) returned HTTP 404 from nuget.org. They must be published before merging to prevent CI/restore failures:
- Codebelt.Extensions.Xunit 10.0.4
- Codebelt.Extensions.Xunit.App 10.0.4
- Cuemon.AspNetCore.Mvc 9.0.7
- Cuemon.Core 9.0.7
- Cuemon.Extensions.AspNetCore 9.0.7
- Cuemon.Extensions.AspNetCore.Authentication 9.0.7
- Cuemon.Extensions.AspNetCore.Mvc 9.0.7
- Cuemon.Extensions.Core 9.0.7
- Cuemon.Extensions.IO 9.0.7
- Cuemon.IO 9.0.7
Please publish these versions to nuget.org (or adjust to existing versions) before merging.
🤖 Prompt for AI Agents
In Directory.Packages.props between lines 6 and 15, the package versions
specified are not yet published on nuget.org, causing HTTP 404 errors during
restore. To fix this, either publish these package versions to nuget.org before
merging or update the version numbers in this file to reference existing
published versions to ensure successful package restore.
|
This pull request includes updates to dependencies, workflows, and Docker configurations to ensure compatibility and improve maintainability. The key changes involve upgrading package versions, updating Dockerfile configurations, and modifying CI/CD workflows.
Dependency Updates:
.nugetrelease notes files to version 9.0.5, highlighting compatibility with .NET 9 and .NET 8, and upgraded dependencies for supported target frameworks. (PackageReleaseNotes.txtfiles: [1] [2] [3] [4]Directory.Packages.propsforCodebelt.Extensions.Xunit,Cuemonlibraries, andMicrosoft.AspNetCore.Mvc.NewtonsoftJson. (Directory.Packages.props: [1] [2]Workflow Updates:
.github/workflows/pipelines.ymlto use versionv2of SonarCloud and CodeQL workflows for improved CI/CD integration. (pipelines.yml: [1] [2]Docker Configuration Updates:
.docfx/Dockerfile.docfxto use a dynamicNGINX_VERSIONargument for better flexibility and maintainability. (Dockerfile.docfx: [1] [2]testenvironments.jsonto use a newer Docker image version for the Ubuntu test runner. (testenvironments.json: testenvironments.jsonL12-R12)Changelog Update:
CHANGELOG.md, summarizing the service update focused on package dependencies. (CHANGELOG.md: CHANGELOG.mdR10-R13)Summary by CodeRabbit