V9.0.7/service update #15
Conversation
WalkthroughVersion increments and documentation updates: bumped NGINX image in DocFX Dockerfile, added an explicit build step in CI for net48, updated central package versions, refreshed test runner Docker image, and added 9.0.7 release notes across changelog and three NuGet package notes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer
participant GH as GitHub Actions
participant Job as Test Job
participant SDK as .NET SDK
participant Test as Test Runner
Dev->>GH: Push/PR
GH->>Job: Trigger workflow
Job->>SDK: Restore (restore: true)
Note right of SDK: net48 requires restore
Job->>SDK: Build (build: true)
Note right of SDK: Newly added step for net48
Job->>Test: Run tests
Test-->>Job: Results
Job-->>GH: Report status
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.nuget/Codebelt.Extensions.AspNetCore.Newtonsoft.Json/PackageReleaseNotes.txt (1)
1-6: Release note reads well; unify “Version” header style across files.Some entries use “Version x.y.z” while older ones use “Version: x.y.z”. Pick one style for consistency going forward.
.nuget/Codebelt.Extensions.AspNetCore.Mvc.Formatters.Newtonsoft.Json/PackageReleaseNotes.txt (1)
1-6: 9.0.7 entry looks good; keep “Version” header punctuation consistent.Match the colon/no‑colon convention used elsewhere in the repo’s NuGet notes.
.nuget/Codebelt.Extensions.Newtonsoft.Json/PackageReleaseNotes.txt (1)
1-6: Notes updated correctly; minor style nit.Standardize “Version” header formatting to reduce churn in future diffs.
.docfx/Dockerfile.docfx (1)
1-1: NGINX 1.29.1-alpine bump LGTM — pin image to sha256 digest (recommended)1.29.1 is a patch release that fixes CVE-2025-53859; pin nginx:${NGINX_VERSION} in both stages (file: .docfx/Dockerfile.docfx) to the exact sha256 digest (e.g. nginx:1.29.1-alpine@sha256: from Docker Hub/manifest) to avoid tag‑drift and supply‑chain risk.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
.docfx/Dockerfile.docfx(1 hunks).github/workflows/pipelines.yml(1 hunks).nuget/Codebelt.Extensions.AspNetCore.Mvc.Formatters.Newtonsoft.Json/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.AspNetCore.Newtonsoft.Json/PackageReleaseNotes.txt(1 hunks).nuget/Codebelt.Extensions.Newtonsoft.Json/PackageReleaseNotes.txt(1 hunks)CHANGELOG.md(1 hunks)Directory.Packages.props(2 hunks)testenvironments.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: call-test (windows-2022, Release) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Release) / 🧪 Test
- GitHub Check: call-test (ubuntu-24.04, Debug) / 🧪 Test
- GitHub Check: call-test (windows-2022, Debug) / 🧪 Test
🔇 Additional comments (4)
CHANGELOG.md (1)
10-13: Changelog entry LGTM; add explicit “no code/API behavior changes” for clarity.
[ suggest_nitpick_refactor ]
Apply this minimal clarification:## [9.0.7] - 2025-09-15 This is a service update that focuses on package dependencies. +No code, API, or behavioral changes.Directory.Packages.props (1)
6-15: Central version bumps LGTM — run vuln/compat sweep locally (dotnet not available here). Cuemon.* and Codebelt.* updates look coherent; I couldn't rundotnet list package --vulnerable --include-transitivein the sandbox. Run locally/CI:dotnet restore && dotnet list package --vulnerable --include-transitiveand verify TargetFramework(s) include net8/net9 (e.g.,rg -nP 'TargetFrameworks?\s*<' --glob '**/*.csproj').testenvironments.json (1)
12-12: Tag exists — confirm image contains both SDKsDocker Hub reports tag net8.0.414-9.0.305 is published. Confirm the image includes both .NET 8 and .NET 9 SDKs (CI/local parity). Context: testenvironments.json (line 12). Quick verification: docker run --rm gimlichael/ubuntu-testrunner:net8.0.414-9.0.305 dotnet --list-sdks
.github/workflows/pipelines.yml (1)
62-63: Gate restore/build to Windows (net48 only).Codebelt's reusable workflow delegates to codebeltnet/dotnet-restore and dotnet-build (they expose restore/build inputs); gate the inputs on Windows and verify the reusable workflow accepts/pass‑through them.
- restore: true # net48 requires restore - build: true # net48 requires build + restore: ${{ matrix.os == 'windows-2022' }} # net48 only on Windows + build: ${{ matrix.os == 'windows-2022' }} # net48 only on WindowsVerify codebeltnet/jobs-dotnet-test/.github/workflows/default.yml@v2 defines/pass‑through the 'restore' and 'build' inputs and accepts boolean-like values.
This pull request is a service update focused on keeping package dependencies and related infrastructure up to date. It upgrades several dependencies to their latest compatible versions, updates release notes, and makes minor adjustments to build and test configurations to ensure compatibility with the latest frameworks.
Dependency updates:
Cuemon.*andCodebelt.*package versions inDirectory.Packages.propsto their latest releases, includingMicrosoft.AspNetCore.Mvc.NewtonsoftJsonfor both .NET 9 and .NET 8 target frameworks. [1] [2]Release notes and documentation:
CHANGELOG.mdand updatedPackageReleaseNotes.txtfiles forCodebelt.Extensions.AspNetCore.Mvc.Formatters.Newtonsoft.Json,Codebelt.Extensions.AspNetCore.Newtonsoft.Json, andCodebelt.Extensions.Newtonsoft.Jsonto reflect dependency upgrades and framework availability. [1] [2] [3] [4]Build and test infrastructure:
testenvironments.jsonfor the Ubuntu test runner to use the latest .NET 8 and .NET 9 patch versions..docfx/Dockerfile.docfxto1.29.1-alpine.pipelines.yml).Summary by CodeRabbit
Documentation
Chores